Serializable Isolation level for SQLite Databases #4693
Merged
Conversation
I've add transaction isolation support for SQLite Warning! SQLite transactions are [serializable by design](https:// www.sqlite.org/isolation.html) but my implementation retuns false in function hasTransactionIsolation and throw an exception in setTransactionIsolation
Comment on lines
+137
to
+154
| switch (ti) | ||
| { | ||
| case Session::TRANSACTION_READ_COMMITTED: | ||
| tmp.add(SQLITE_READ_COMMITTED); | ||
| _transactionIsolationLevel = Session::TRANSACTION_READ_COMMITTED; | ||
| break; | ||
| case Session::TRANSACTION_READ_UNCOMMITTED: | ||
| tmp.add(SQLITE_READ_UNCOMMITTED); | ||
| _transactionIsolationLevel = Session::TRANSACTION_READ_UNCOMMITTED; | ||
| break; | ||
| case Session::TRANSACTION_REPEATABLE_READ: | ||
| throw Poco::InvalidArgumentException("setTransactionIsolation(TRANSACTION_REPEATABLE_READ) - unsupported"); | ||
| case Session::TRANSACTION_SERIALIZABLE: | ||
| throw Poco::InvalidArgumentException("setTransactionIsolation(TRANSACTION_SERIALIZABLE) - unsupported [SQLite transactions are serializable by design]"); | ||
| default: | ||
| throw Poco::InvalidArgumentException(Poco::format("setTransactionIsolation(%u) - unsupported", ti)); | ||
| break; | ||
| } |
Check warning
Code scanning / CodeQL
Use of integer where enum is preferred
Comment on lines
+167
to
+177
| switch (ti) | ||
| { | ||
| case Session::TRANSACTION_READ_COMMITTED: | ||
| return true; | ||
| case Session::TRANSACTION_READ_UNCOMMITTED: | ||
| return true; | ||
| case Session::TRANSACTION_REPEATABLE_READ: | ||
| return false; | ||
| case Session::TRANSACTION_SERIALIZABLE: | ||
| return false; | ||
| } |
Check warning
Code scanning / CodeQL
Use of integer where enum is preferred
Contributor
Hi! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.