Merged
Conversation
aleks-f
approved these changes
Sep 14, 2024
obiltschnig
requested changes
Sep 25, 2024
Member
There was a problem hiding this comment.
Some changes seem to be missing. E.g., the version number in expat.h and expat_config.h have not been updated. Also, winconfig.h is not needed. The changes in xmlrole.c and xmltok.c are not needed.
For reference, compare the expat release with the previous one.
0513590 to
9a7da6d
Compare
Contributor
Author
I corrected all files except expat_config.h which doesn't seem to contain expat version info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes.
Fixes #4123.
https://github.com/libexpat/libexpat/blob/R_2_6_3/expat/Changes