Merged
Conversation
Allow for unbundled LibPNG as used in many libraries using Poco
matejk
reviewed
Aug 29, 2024
Contributor
Author
|
@matejk added PDF to ci test |
Contributor
|
@danoli3, unfortunately build and test does not pass. https://github.com/pocoproject/poco/actions/runs/10611386593/job/29410801465?pr=4657 |
Contributor
Author
|
LIBPNG to PNG for find package. Reference a blog speaking about building Poco actually haha https://fedetft.wordpress.com/2010/03/07/cmake-part-3-finding-libraries/ LIBPNG for pkgconfig I think |
Contributor
Author
|
@matejk sweet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Poco!
This PR adds the desired "UNBUNDLED=1" LibPNG separation.
Changes to CMakeLists and ci
As LibPNG is widely used as a dependancy, using both Poco and LibPNG has meant no Poco.
Allow Poco back plz