Skip to content

fix(SimpleFileChannel): unify default "flush" to be false as it is in FileChannel#4622

Merged
aleks-f merged 1 commit intomainfrom
4591_simple-file-channel-flush-unified
Aug 17, 2024
Merged

fix(SimpleFileChannel): unify default "flush" to be false as it is in FileChannel#4622
aleks-f merged 1 commit intomainfrom
4591_simple-file-channel-flush-unified

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Jul 30, 2024

Closes #4591.

@matejk matejk added this to the Release 1.14.0 milestone Jul 30, 2024
@matejk matejk requested a review from aleks-f July 30, 2024 18:54
@aleks-f aleks-f merged commit 7345bf3 into main Aug 17, 2024
@aleks-f aleks-f deleted the 4591_simple-file-channel-flush-unified branch August 17, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Performance(time) affected because of PR #4429 in LogFileImpl::writeImpl FLUSH. #4429 #2443 code changes due to this has impacted performance.

2 participants