enh(FileStream): Add FileStreamBuf::resizeBuffer#4621
Merged
Conversation
Comment on lines
+451
to
+453
| // Measurements in test environment are not reliable enough. | ||
| //assertTrue(writeDefUs > writeLargeUs); | ||
| //assertTrue(readDefUs > readLargeUs); |
Check notice
Code scanning / CodeQL
Commented-out code
…al buffers. Larger buffers improve performance significantly when streaming large quantity of data on very fast devices.
5979d05 to
e4b1538
Compare
aleks-f
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Larger internal buffers improve performance significantly when streaming large quantity of data on very fast devices.
New function provides an option to change the default hard-coded internal buffer size.
It may be changed only when file is not open.