Closed
Conversation
Contributor
OgreTransporter
commented
Jul 21, 2024
- Upgrade bundled SQLite to 3.46.0
- Upgrade bundled zlib to 1.3.1 (see Update of libpng and zlib in component PDF #4582)
- Upgrade bundled libpng to 1.6.43 (see Update of libpng and zlib in component PDF #4582)
- Upgrade bundled pcre2 to 10.44 (see Upgrade bundled PCRE2 to 10.44 #4478)
Closed
Comment on lines
+278
to
+283
| if (((c >= CHAR_0 && c <= CHAR_9) || | ||
| (c >= CHAR_A && c <= CHAR_F) || | ||
| (c >= CHAR_a && c <= CHAR_f) || | ||
| (c >= 0xff10 && c <= 0xff19) || /* Fullwidth digits */ | ||
| (c >= 0xff21 && c <= 0xff26) || /* Fullwidth letters */ | ||
| (c >= 0xff41 && c <= 0xff46)) == isprop) |
Check notice
Code scanning / CodeQL
Complex condition
| break; /* Hex escape not recognized */ | ||
| { | ||
| escape = ESC_ub; /* Special return */ | ||
| ptr++; /* Skip { */ |
Check notice
Code scanning / CodeQL
Commented-out code
| { | ||
| PCRE2_SPTR p = ptr + 1; | ||
|
|
||
| /* Perl ignores spaces and tabs after { */ |
Check notice
Code scanning / CodeQL
Commented-out code
aleks-f
requested changes
Jul 24, 2024
Member
aleks-f
left a comment
There was a problem hiding this comment.
for some reason, the PR CI is not triggered, but the last commit CI fails massively, please se why
Contributor
Author
|
I have already created the fix 6a311fd, but it did not repeat the complete action. Can you trigger this manually? |
matejk
reviewed
Jul 29, 2024
PDF/CMakeLists.txt
Outdated
| src/pngwio.c | ||
| src/pngwrite.c | ||
| src/pngwtran.c | ||
| src/pngwutil.c |
Contributor
There was a problem hiding this comment.
Unnecessary change of white space (tabs to spaces).
Is the list of source file shorter by three files intentionally or by accident?
Member
|
@OgreTransporter you have some CI failing |
This was referenced Sep 11, 2024
Merged
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.