Conversation
|
|
||
| for (int i = 0; i < 200; i++) | ||
| { | ||
| Message msgInfA("InformationSource", "e Informational sync message", Message::PRIO_INFORMATION); |
Check notice
Code scanning / CodeQL
Declaration hides variable
… pending messages. (#4529)
7fe24c0 to
54b6e21
Compare
| Message msgInfA("InformationSource", "e Informational sync message", Message::PRIO_INFORMATION); | ||
| pChannel->log(msgInfA); | ||
| } | ||
| //pChannel->stop(); |
Check notice
Code scanning / CodeQL
Commented-out code
…ject/poco into 4529-sql-logger-shutdown
matejk
reviewed
Jul 16, 2024
matejk
reviewed
Jul 16, 2024
matejk
reviewed
Jul 16, 2024
matejk
approved these changes
Jul 16, 2024
Contributor
matejk
left a comment
There was a problem hiding this comment.
I think that PR is OK.
Few comments for minor improvements added.
…cation with lambda; update comments #4529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.