Merged
Conversation
Contributor
|
fixes #2208 |
matejk
reviewed
Mar 30, 2024
matejk
reviewed
Mar 30, 2024
matejk
reviewed
Mar 30, 2024
matejk
requested changes
Apr 2, 2024
Contributor
There was a problem hiding this comment.
DNSSD does not compile on macOS with XCode and MacOSX14.4.sdk:
FindBounjour.cmake does not set library and include variables on Apple platforms.
After fixing that (DNSSD is a part of CoreServices, no additional include directory required) compile fails because enum value kDNSServiceFlagsNonBrowsable is not defined in Apple's dns_sd.h.
/Users/matejk/git/github/poco/DNSSD/Bonjour/src/BonjourResponderImpl.cpp:83:60: error: use of undeclared identifier 'kDNSServiceFlagsNonBrowsable'; did you mean 'kDNSServiceFlagsNoAutoRename'?
if (options & DNSSDResponder::REG_NON_BROWSABLE) flags |= kDNSServiceFlagsNonBrowsable;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
kDNSServiceFlagsNoAutoRename
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/dns_sd.h:286:5: note: 'kDNSServiceFlagsNoAutoRename' declared here
kDNSServiceFlagsNoAutoRename = 0x8,
^
It was removed in version 1096.0.2 (January 2020).
Older versions of dns_sd.h from (https://github.com/apple-oss-distributions/mDNSResponder) still have this value.
kDNSServiceFlagsNonBrowsable = 0x2000,
/* A service registered with the NonBrowsable flag set can be resolved using
* DNSServiceResolve(), but will not be discoverable using DNSServiceBrowse().
* This is for cases where the name is actually a GUID; it is found by other means;
* there is no end-user benefit to browsing to find a long list of opaque GUIDs.
* Using the NonBrowsable flag creates SRV+TXT without the cost of also advertising
* an associated PTR record.
*/
matejk
reviewed
Apr 2, 2024
matejk
reviewed
Apr 2, 2024
matejk
reviewed
Apr 2, 2024
DNSSD/Bonjour/include/Poco/DNSSD/Bonjour/BonjourResponderImpl.h
Outdated
Show resolved
Hide resolved
matejk
reviewed
Apr 2, 2024
matejk
reviewed
Apr 2, 2024
matejk
reviewed
Apr 2, 2024
matejk
approved these changes
Apr 3, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #4323