Allow using Poco::FileStream to wrap arbitrary file handles/descriptors as C++ streams #4424
Merged
Allow using Poco::FileStream to wrap arbitrary file handles/descriptors as C++ streams #4424
Conversation
aleks-f
requested changes
Jan 30, 2024
Member
aleks-f
left a comment
There was a problem hiding this comment.
a testcase should be added.
this should be released in 1.14 - it changes the interface, so it is more appropriate to introduce it in major release
931b122 to
f424e62
Compare
…rs as C++ streams (#3444). * Allow opening a file descriptor/HANDLE as C++ stream. * FileStream: treat read from closed pipe as EOF. * chore(Filestream): conde style (naming) Co-Authored-By: Alex Fabijanic <alex@pocoproject.org> Co-Authored-By: Matej Kenda <matejken@gmail.com>
f424e62 to
59507e4
Compare
057448a to
e4ec513
Compare
e4ec513 to
d7613d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains PR #3444 rebased on latest devel.
Allow opening a file descriptor/HANDLE as C++ stream.
FileStream: treat read from closed pipe as EOF.
chore(Filestream): conde style (naming)