fix(Environment): define _USE_32BIT_TIME_T on 32-bit Windows#4405
Closed
fix(Environment): define _USE_32BIT_TIME_T on 32-bit Windows#4405
Conversation
Member
|
Very probably it should also be set in the .vcxproj files. This will require adding the setup to the .progen file and then re-generating the project files. |
…TIME_T to be set.
87293b5 to
bca43d0
Compare
Member
Contributor
Author
|
The define is set only when compiling a single file, not complete project. Alternative is to use different function as written in the related issue. |
Member
|
I'm not sure if progen is currently capable of doing this. I'd say, never mind the VS solutions; they are not officially supported, and if someone needs it, they can do it and send a pull. Everyone else has cmake-generated projects. |
Contributor
Author
|
This PR does not contain optimal solution. GetAdaptersAddresses shall be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling
Environment_WIN32U.cppon 32-bit Windows it is required to set the compiler definition-D_USE_32BIT_TIME_Tto be able to properly use system callGetAdaptersInfo.Unfortunately it must be set on the compiler command line. It does not work if it is set inside the cpp file. Foundation CMake file was therefore modified to set the define for a single file.
Is it necessary to have this for VS project files also? Is Poco still compiled with VS projects on 32-bit Windows?
PR also includes an improvement to pre-allocate larger buffer for network adapters to avoid scanning for available adapters for mist common situations.