enh(DateTimeParser): option to cleanup input string before parsing (#569)#4390
Merged
enh(DateTimeParser): option to cleanup input string before parsing (#569)#4390
Conversation
aleks-f
requested changes
Jan 14, 2024
Member
aleks-f
left a comment
There was a problem hiding this comment.
I say, just trim surrounding spaces indiscriminately and let's leave it at that, no additional functions and no future deprecation.
|
I agree with Aleks, let's just trim, document this, so a committed feature, and nothing more. |
aleks-f
reviewed
Jan 14, 2024
185ad6c to
4453cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a second set of
parsefunctions with a new argumentcleanupto explicitly request the input string to be cleaned.Existing
parseandtryParseperform cleanup. These could be marked as deprecated to issue compiler warnings to transition to stricter checking by default in one of the next releases.@killerbot242, @aleks-f : what is your opinion on this?