fix(NamedEvent): Release semaphore ID in dtor when created with semget (fixes #2971)#4357
Merged
fix(NamedEvent): Release semaphore ID in dtor when created with semget (fixes #2971)#4357
Conversation
eecf927 to
bee5a2a
Compare
Contributor
Author
|
Releasing semaphore IDs on Linux seems to be solved, however it seems that named event is not correctly implemented on macOS also. The following test throws exception with errno 28 (ENOSPC):
|
bee5a2a to
4b7ac25
Compare
4b7ac25 to
bf451e5
Compare
bf451e5 to
95c5609
Compare
95c5609 to
92ec50b
Compare
a534bd4 to
75824cd
Compare
Contributor
Author
|
@aleks-f , @obiltschnig , please take a look at this PR. It seems to work properly, however I am not 100% percent familiar with NamedEvent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a semaphore id is created with semget, it is released in dtor with semctl(..IPC_RMID).