Fix some issues found with clang-tidy#4353
Merged
matejk merged 4 commits intopocoproject:develfrom Dec 17, 2023
Merged
Conversation
added 4 commits
December 16, 2023 23:57
Add missing inline to inline function. This was found with clang-tidy check: misc-definitions-in-headers
throw() has been deprecated in standar in C++17. It has been removed in C++20. Code still compiles but let's just define these at those should be. These where found with clang-tidy check: modernize-use-noexcept
Clang-tidy did find these with check: performance-unnecessary-copy-initialization
Looks like these are just missing reference marks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang-tidy did find some problems from code. I choose to fix these separately as it makes it easier to automate clang-tidy at some point.
Every commit has own fix type and they have messages. Look them separately so reviewing is easier.