Skip to content

macOS sanitizer github jobs (fixes #4313)#4346

Merged
matejk merged 5 commits intodevelfrom
4313-macos-sanitizer-jobs
Jan 5, 2024
Merged

macOS sanitizer github jobs (fixes #4313)#4346
matejk merged 5 commits intodevelfrom
4313-macos-sanitizer-jobs

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Dec 15, 2023

Github jobs for macOS with sanitize options: undefined, address, thread.

#4313, #4347

@matejk matejk added this to the Release 1.13.0 milestone Dec 15, 2023
@matejk matejk marked this pull request as draft December 15, 2023 15:21
@matejk matejk force-pushed the 4313-macos-sanitizer-jobs branch 2 times, most recently from 3a2b1ee to 277e5c9 Compare December 15, 2023 18:43
@matejk matejk modified the milestones: Release 1.13.0, Release 1.13.1 Dec 15, 2023
@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Dec 16, 2023

@pavledragisic FYI, this (TSAN build clang/osx) most likely won't go into 1.13 but should definitely be looked at

EDIT: apparently, the link to the exact location does not work, so here:

There was 1 error: 
 1: CppUnit::TestCaller<ProcessRunnerTest>.testProcessRunner
    "Poco::NotFoundException:
Not found: cannot terminate process"
    in "<unknown>", line -1

@matejk matejk force-pushed the 4313-macos-sanitizer-jobs branch from 277e5c9 to 125ed20 Compare December 22, 2023 08:33
@matejk matejk force-pushed the 4313-macos-sanitizer-jobs branch from 125ed20 to 4c24606 Compare January 3, 2024 16:00
@matejk matejk changed the base branch from devel to poco-1.13.1 January 3, 2024 16:00
@matejk matejk marked this pull request as ready for review January 3, 2024 20:39
@matejk matejk requested a review from aleks-f January 3, 2024 20:40
@matejk matejk force-pushed the 4313-macos-sanitizer-jobs branch from cf565bf to 2e58aec Compare January 5, 2024 07:13
@matejk matejk changed the base branch from poco-1.13.1 to devel January 5, 2024 07:15
@matejk
Copy link
Copy Markdown
Contributor Author

matejk commented Jan 5, 2024

@aleks-f, This PR is ready to be merged if you agree.

CppUnit::TestCaller<SyslogTest>.testOldBSD,
CppUnit::TestCaller<PollSetTest>.testPollClosedServer,
CppUnit::TestCaller<CryptoTest>.testEncryptDecryptGCM"
CppUnit::TestCaller<PollSetTest>.testPollClosedServer"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be looked into when working on #4382; not being able to detect the server closing connection is a problem

@matejk matejk merged commit 0f25b4c into devel Jan 5, 2024
@matejk matejk deleted the 4313-macos-sanitizer-jobs branch January 5, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github check job on macOS: testEncryptDecryptGCM occasionally fails Add macos sanitizer CI jobs

2 participants