Fix RemoteSyslogChannel setProperty value check#4339
Merged
aleks-f merged 1 commit intopocoproject:develfrom Dec 13, 2023
Merged
Fix RemoteSyslogChannel setProperty value check#4339aleks-f merged 1 commit intopocoproject:develfrom
aleks-f merged 1 commit intopocoproject:develfrom
Conversation
We compare just 4 first letters. So if value would have example be syslevel then this function would work wrong. Nothing major but nice to fix.
Contributor
Author
|
Kinda better fix imo would be to make also iStartsWith() and iEndsWith(). This kind of situation would not happen with those. If wanted I can do those also and use those where needed. At least we have missed those in our project where Poco is used. Now we use those from other libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RemoteSyslogChannel::setProperty we compare just 4 first letters. So if value would have example be syslevel then this function would work wrong. Nothing major but nice to fix.