Throw exceptions when node ID retrieval is unsuccessful and support Wireless Adapters on Windows#4336
Merged
matejk merged 4 commits intopocoproject:develfrom Dec 14, 2023
Merged
Conversation
teksturi
reviewed
Dec 12, 2023
teksturi
reviewed
Dec 12, 2023
matejk
reviewed
Dec 12, 2023
teksturi
reviewed
Dec 12, 2023
13a1b10 to
fd7c52e
Compare
… wireless adapters on Windows when ethernet adapters are not found.
…eworking windows adapter info to not need new and reinterpret_cast.
fd7c52e to
70b7077
Compare
teksturi
reviewed
Dec 14, 2023
Removing bool found as it is no longer required.
teksturi
approved these changes
Dec 14, 2023
Contributor
teksturi
left a comment
There was a problem hiding this comment.
To my eayes everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for issue #4328. Throwing exceptions for nodeIdImpl on Linux and adding support for Wireless Adapters on Windows.