Usage modern C++ features on JSON modules#4085
Usage modern C++ features on JSON modules#4085cngzhnp wants to merge 4 commits intopocoproject:develfrom
Conversation
|
This is little bit old PR already but I still answer this. It does not make much sense to change style for just small portion of code base. It would be much better to do just one change at time. Example this
could be done to whole repo. It would be much more easy to accept those kind of changes. |
Hello @teksturi, sorry for late answer. However, my intention was not just a change into small portion of codebase like this, also I am not fan of inconsistent things. I just want to split up code review based on submodules. Creating a PR with 100 files changed which was not easy to review and apply changes. So, doing it step by step would be much better idea at least for me at that time. |
|
@matejk |
|
@cngzhnp, would you be willing to rebase this PR to main? |
Remove zero-width space from start of file
…e encoded words (pocoproject#4542) * fix bug pocoproject#4535 RFC 2047 decodeWord * modify logic uses separate string which contains simbols between chunks and if this string contains only space ot \n or \t or \v than trim it
fb275a1 to
d3b7947
Compare
|
PR #4613 was created from these changes. See details there. Closing this PR. |
Starting from this module, I want to use modern C++ features such as:
nullptrinstead of 0.autoinstead of iterator type itself.defaultkeyword instead of copy constructor, destructor implementationoverridekeyword if necessary.usingkeyword instead oftypedef.empty()call instead ofobject.size() == 0