Skip to content

rename arc -> poco_arc#4050

Merged
obiltschnig merged 1 commit intopocoproject:develfrom
stkw0:devel
Jun 12, 2023
Merged

rename arc -> poco_arc#4050
obiltschnig merged 1 commit intopocoproject:develfrom
stkw0:devel

Conversation

@stkw0
Copy link
Copy Markdown
Contributor

@stkw0 stkw0 commented Jun 8, 2023

Fix #3349

@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Jun 10, 2023

@stkw0 there is also Makefile:

poco/ActiveRecord/Compiler/Makefile

Line 11 in 2a6434a

target = arc

and VS projects.

@aleks-f aleks-f requested a review from obiltschnig June 10, 2023 02:31
@stkw0
Copy link
Copy Markdown
Contributor Author

stkw0 commented Jun 12, 2023

For VS is enough to change Compiler.progen file or it's requires also to sed -i 's/arc/poco_arc/g' Compiler_vs* ? Never used VS

@obiltschnig
Copy link
Copy Markdown
Member

obiltschnig commented Jun 12, 2023

I'd prefer poco-arc as underscores are rather uncommon in executable names.
Regarding VS, just update the .progen file.

@obiltschnig obiltschnig merged commit 67d0c05 into pocoproject:devel Jun 12, 2023
@obiltschnig obiltschnig added this to the Release 1.12.5 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obiltschnig obiltschnig Awaiting requested review from obiltschnig

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 1.12.5

Development

Successfully merging this pull request may close these issues.

Consider renaming ActiveRecord binary from arc

3 participants

@stkw0 @aleks-f @obiltschnig