Skip to content

Make Binding and CopyBinding specializations final#4022

Merged
aleks-f merged 1 commit intopocoproject:develfrom
OwenKnight-FLINTpro:feat/clang-diagnostic-warn-fix
Nov 27, 2023
Merged

Make Binding and CopyBinding specializations final#4022
aleks-f merged 1 commit intopocoproject:develfrom
OwenKnight-FLINTpro:feat/clang-diagnostic-warn-fix

Conversation

@OwenKnight-FLINTpro
Copy link
Copy Markdown
Contributor

The Binding specializations call it virtual functions numOfRowsHandled() and reset() from their constructors. This is fine assuming virtual function dispatch to a further derived class was not intended. In this case the assumption is solid, however this triggers the Clang diagnostic clang-analyzer-optin.cplusplus.VirtualCall

Adding the final specifyer to these specializations gives Clang enough of a hint to silence

The Binding specializations call it virtual functions numOfRowsHandled()
and reset() from their constructors. This is fine assuming virtual
function dispatch to a further derived class was not intended. In this
case the assumption is solid, however this triggers the Clang diagnostic
clang-analyzer-optin.cplusplus.VirtualCall

Adding the final specifyer to these specializations gives Clang enough
of a hint to silence
@OwenKnight-FLINTpro OwenKnight-FLINTpro marked this pull request as ready for review May 1, 2023 02:44
@aleks-f aleks-f added this to the Release 1.13.0 milestone Jun 21, 2023
@aleks-f aleks-f self-assigned this Jun 21, 2023
@aleks-f aleks-f merged commit 9141368 into pocoproject:devel Nov 27, 2023
@OwenKnight-FLINTpro OwenKnight-FLINTpro deleted the feat/clang-diagnostic-warn-fix branch November 27, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants