Make Binding and CopyBinding specializations final#4022
Merged
aleks-f merged 1 commit intopocoproject:develfrom Nov 27, 2023
Merged
Make Binding and CopyBinding specializations final#4022aleks-f merged 1 commit intopocoproject:develfrom
aleks-f merged 1 commit intopocoproject:develfrom
Conversation
The Binding specializations call it virtual functions numOfRowsHandled() and reset() from their constructors. This is fine assuming virtual function dispatch to a further derived class was not intended. In this case the assumption is solid, however this triggers the Clang diagnostic clang-analyzer-optin.cplusplus.VirtualCall Adding the final specifyer to these specializations gives Clang enough of a hint to silence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Binding specializations call it virtual functions numOfRowsHandled() and reset() from their constructors. This is fine assuming virtual function dispatch to a further derived class was not intended. In this case the assumption is solid, however this triggers the Clang diagnostic clang-analyzer-optin.cplusplus.VirtualCall
Adding the final specifyer to these specializations gives Clang enough of a hint to silence