Skip to content

Fix compile with -DPOCO_NET_NO_IPv6#4021

Merged
aleks-f merged 1 commit intopocoproject:masterfrom
gelldur:fix_POCO_NET_NO_IPv6
May 5, 2023
Merged

Fix compile with -DPOCO_NET_NO_IPv6#4021
aleks-f merged 1 commit intopocoproject:masterfrom
gelldur:fix_POCO_NET_NO_IPv6

Conversation

@gelldur
Copy link
Copy Markdown

@gelldur gelldur commented Apr 28, 2023

Fixed compile with -DPOCO_NET_NO_IPv6

@gelldur
Copy link
Copy Markdown
Author

gelldur commented May 5, 2023

Failing CI as I can tell is not fault of this change.

@aleks-f aleks-f added this to the Release 1.13.0 milestone May 5, 2023
@aleks-f aleks-f merged commit f4bd7c2 into pocoproject:master May 5, 2023
@gelldur
Copy link
Copy Markdown
Author

gelldur commented Jan 24, 2024

@aleks-f this PR was merged to master but on current master those changes do not exist.
https://github.com/pocoproject/poco/blob/master/Net/src/HTTPClientSession.cpp
I can't even find in history related changes.

Did someone force push?
Does -DPOCO_NET_NO_IPv6 is still relevant ?

@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Jan 25, 2024

@gelldur I am not quite sure anymore how or why I merged this into master - nothing should go there except the releases. There's been quite a bit of discrepancies between release branches and devel since the 1.11 series and we're still recovering from that - that's the best explanation I have.

Long story short, I am sorry for dropping this one; please send a pull to devel branch and we'll release it in 1.13.1

@gelldur
Copy link
Copy Markdown
Author

gelldur commented Jan 26, 2024

Thank you, that is all I need. I will resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

Release 1.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gelldur @aleks-f