fix(Crypto) Update method to extract friendlyName from certificate#3787
Merged
aleks-f merged 7 commits intopocoproject:develfrom Sep 11, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
in single codebase I need to use webrtc with BoringSSL and Poco.
I ran into a few problems compiling poco with BoringSSL, I'll try to suggest some changes to make it easier for others.
First things first: the current
extractFriendlyNamemethod doesn't compile with BoringSSL, I asked the BoringSSL team for advice and I have a tip on that:https://bugs.chromium.org/p/boringssl/issues/detail?id=515
The discussion shows that this is a compatible change with a positive effect on the current code.
I run the Crypto test suite and it returned:
BTW: These changes are not
BoringSSLspecific.