Skip to content

add self to path#3758

Closed
JackyWoo wants to merge 9 commits intopocoproject:develfrom
JackyWoo:add_self_to_path
Closed

add self to path#3758
JackyWoo wants to merge 9 commits intopocoproject:develfrom
JackyWoo:add_self_to_path

Conversation

@JackyWoo
Copy link
Copy Markdown
Contributor

@JackyWoo JackyWoo commented Aug 18, 2022

This pr try to close #2282

@JackyWoo
Copy link
Copy Markdown
Contributor Author

JackyWoo commented Aug 18, 2022

@aleks-f Some OS such as FreeBSD not tested for less of CI tasks.

aleks-f
aleks-f requested changes Aug 18, 2022
View reviewed changes
Foundation/testsuite/src/PathTest.cpp
Path p(self);
assertTrue(p.isAbsolute());
assertTrue(p.isFile());
assertTrue(self.find("testrunner") != std::string::npos);
Copy link
Copy Markdown
Member

@aleks-f aleks-f Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test must somehow be skipped on windows because the executable is named TestSuite there

Copy link
Copy Markdown
Contributor Author

@JackyWoo JackyWoo Sep 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleks-f I skipped an assertion on Windows. Or you mean skip testSelf on Windows?

Copy link
Copy Markdown
Member

@aleks-f aleks-f Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackyWoo windows should be tested

@JackyWoo JackyWoo requested a review from aleks-f August 19, 2022 04:50
@JackyWoo
Copy link
Copy Markdown
Contributor Author

JackyWoo commented Sep 5, 2022

@aleks-f Pls review if you have a changce.

1 test error, maybe unrelated.

There was 1 failure: 
 1: class CppUnit::TestCaller<class PollSetTest>.testPollClosedServer
    "fail: "
    in "<unknown>", line -1

@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Sep 6, 2022

@aleks-f Pls review if you have a changce.

I did review, but I do not se anything done about it

@JackyWoo
Copy link
Copy Markdown
Contributor Author

JackyWoo commented Dec 30, 2022

@aleks-f I wonder whether Skip PathTest::testSelf on Windows is what your meaning

@aleks-f aleks-f added this to the Release 1.13.0 milestone Mar 17, 2023
aleks-f
aleks-f requested changes Mar 17, 2023
View reviewed changes
aleks-f
aleks-f requested changes Mar 17, 2023
View reviewed changes
Foundation/testsuite/src/PathTest.cpp
Path p(self);
assertTrue(p.isAbsolute());
assertTrue(p.isFile());
assertTrue(self.find("testrunner") != std::string::npos);
Copy link
Copy Markdown
Member

@aleks-f aleks-f Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackyWoo windows should be tested

@aleks-f aleks-f removed this from the Release 1.13.0 milestone Mar 17, 2023
@JackyWoo JackyWoo requested a review from aleks-f March 22, 2023 12:41
@aleks-f aleks-f added this to the Release 1.13.0 milestone Jun 10, 2023
@aleks-f aleks-f self-assigned this Jun 10, 2023
@matejk matejk mentioned this pull request Dec 4, 2023
Merged
@aleks-f aleks-f removed this from the Release 1.13.0 milestone Dec 4, 2023
@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Dec 4, 2023

#4319

@aleks-f aleks-f closed this Dec 4, 2023
aleks-f
aleks-f reviewed Dec 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleks-f aleks-f aleks-f requested changes

Assignees

@aleks-f aleks-f

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Path::self()

2 participants

@JackyWoo @aleks-f