Fixed Crash in WinService::setFailureActions#2919
Merged
obiltschnig merged 1 commit intopocoproject:poco-1.10.1from Feb 12, 2020
Merged
Fixed Crash in WinService::setFailureActions#2919obiltschnig merged 1 commit intopocoproject:poco-1.10.1from
obiltschnig merged 1 commit intopocoproject:poco-1.10.1from
Conversation
less then 3 Elements. Also the Function crashes if no SVC_REBOOT or SVC_RUN_COMMAND are specified. If this is the case ac.lpCommand and ac.lpRebootMessage are not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are 2 Situations in which the setFailureActions could crash.
SVC_REBOOTandSVC_RUN_COMMANDis specified. In that case theac.lpCommandandac.lpRebootMsgParameters are not set.This commit should fix boths of the Situations.
The Function now throws an
InvalidArgumentException if the Size of the Vector is larger then 3 Elements