Skip to content

MongoDB: disable unwanted release of resources in PooledConnection#1146

Merged
aleks-f merged 1 commit intopocoproject:developfrom
matejk:gh-860
May 5, 2016
Merged

MongoDB: disable unwanted release of resources in PooledConnection#1146
aleks-f merged 1 commit intopocoproject:developfrom
matejk:gh-860

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Feb 3, 2016

Using copy ctor or assignment operator could release the connection when not desired.

Disabled copy semantics.

Added move semantics if C++11 functionality is enabled.

Fixes: #860

… semantics. Enabled move semantics for C++11.
@aleks-f aleks-f added this to the Release 2.0.0 milestone Mar 12, 2016
@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Mar 12, 2016

if it has c++11 features, it should go into c++11 branch

@matejk
Copy link
Copy Markdown
Contributor Author

matejk commented Mar 15, 2016

C++11 features are wrapped with POCO_ENABLE_CPP11. If they are not enabled then just copy ctor is disabled by making it private.

@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Mar 15, 2016

I'l merge as soon as @fbraem reviews and approves

@fbraem
Copy link
Copy Markdown
Member

fbraem commented May 3, 2016

I'm not familiar yet with C++11 features, but to me it's ok to disallow copy constructors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants