Fix for bug in MailMessage without content-transfer-encoding header#386
Merged
obiltschnig merged 1 commit intopocoproject:developfrom Mar 9, 2014
Merged
Conversation
(http://pocoproject.org/forum/viewtopic.php?f=12&t=6106&sid=9283682f915ea148d86813ea140cd3c7). MailMessage was not handling encoding when no Content-Transfer-Encodign header was not present for MultiPart messages, resulting on an Exception. His fix checks if the header is present before getting is value, and defaults to 7bit encoding as in http://www.w3.org/Protocols/rfc1341/5_Content-Transfer-Encoding.html
obiltschnig
added a commit
that referenced
this pull request
Mar 9, 2014
Fix for bug in MailMessage without content-transfer-encoding header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for bug in MailMessage reported on forum (http://pocoproject.org/forum/viewtopic.php?f=12&t=6106&sid=9283682f915ea148d86813ea140cd3c7).
MailMessage was not handling encoding when Content-Transfer-Encoding
header was not present for MultiPart messages, resulting on an
Exception. This fix checks if the header is present before getting is
value, and just defaults to 7bit encoding if there is no header as described in
http://www.w3.org/Protocols/rfc1341/5_Content-Transfer-Encoding.html
I also add two new tests to cover both simple and multipart messages with no Content-Transfer-Encoding headers.