Add convertation to string in Redis Command#set#3519
Closed
102Rudy wants to merge 1 commit intopocoproject:develfrom
Closed
Add convertation to string in Redis Command#set#3519102Rudy wants to merge 1 commit intopocoproject:develfrom
102Rudy wants to merge 1 commit intopocoproject:develfrom
Conversation
Author
|
@obiltschnig Hey! Will we merge that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem in
Poco::Redis::Command::set(...)If I want to set expire time for the value, I can't just write:
That doesn't work because of incorrect implementation of the
setfunction: whenexpireTimeis added tocmdit's not converted fromInt64tostd::string.This PR fixes the issue.