Fix crash due to X.509 certificates with Subject Alternative Name other than DNS Host#3397
Closed
echo-branch wants to merge 8 commits intopocoproject:masterfrom
Closed
Fix crash due to X.509 certificates with Subject Alternative Name other than DNS Host#3397echo-branch wants to merge 8 commits intopocoproject:masterfrom
echo-branch wants to merge 8 commits intopocoproject:masterfrom
Conversation
Author
|
@obiltschnig |
Author
|
Just want to share detailed repro steps with Kaspersky. Though any X.509 certificate with SAN entries other than DNS Host will also repro the issue.
|
Member
|
See 270c264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #3221.
Modified
X509Certificate.cppto skip Subject Alternative Name entries other than DNS Host. This fixes a crash.Modified
SecureSocketImpl.cppto fix an error check issue. The comment indicates the code should have ignored errors other than CRYPT_E_REVOKED, howeverrevStat.dwIndex < certs.size() - 1is true when you have any error.