Skip to content

SocketReactor::getNotifier() does not use socket.impl() #3371

@micheleselea

Description

@micheleselea

I think the function
SocketReactor::NotifierPtr SocketReactor::getNotifier(const Socket& socket, bool makeNew)
was not changed to reflect the change you made to PollSet.
getNotifier use socket and not socket.impl()->sockfd();
Probably you end up with that solution that is ok anyway? I remember the reason was that if the fd change (for example when you need to upgrade from non SSL to SSL connection inside handler) something can go wrong...but was almost 1 year ago and I don't know if I remember correctly

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions