Fix pkg-name in find_package_handle_standard_args#3067
Fix pkg-name in find_package_handle_standard_args#3067Krzmbrzl wants to merge 1 commit intopocoproject:masterfrom
Conversation
For the MySQL package find_package_handle_standard_args got passed "MYSQL" as the package name, which differs from the actual package name. Due to this cmake (3.18) emitted a warning. This commit fixes this issue by also passing "MySQL" to find_package_handle_standard_args. Fixes pocoproject#3066
|
But still the question is, should we also "camel-case" the other Variable Names? But this will break others build system. Maybe rename |
Yeah that'd probably have to be done as well 🤔
By renaming the FindMYSQL, it should not interfere with any project using poco, should it? In that case I don't even see the need for providing a FindMySQL at all 👀 |
|
Leaving it at FindMySQL.cmake for now, as we have the same issue with PostgreSQL. |
For the MySQL package find_package_handle_standard_args got passed "MYSQL" as the package name, which differs from
the actual package name. Due to this cmake (3.18) emitted a warning.
This commit fixes this issue by also passing "MySQL" to find_package_handle_standard_args.
Fixes #3066