Skip to content

SocketImpl::bind --> bind wrong config #2892

@AdrianGersbach-EH

Description

@AdrianGersbach-EH

Until v1.9.0 SocketImpl::bind used to look like this
void SocketImpl::bind(const SocketAddress& address, bool reuseAddress)
{
bind(address, reuseAddress, true);
}

Starting with v1.9.1 SocketImpl::bind changed the true to reuseAddress.
void SocketImpl::bind(const SocketAddress& address, bool reuseAddress)
{
bind(address, reuseAddress, reuseAddress);
}

I think this is incorrect since bind6 still uses true for reusePort.
void SocketImpl::bind6(const SocketAddress& address, bool reuseAddress, bool ipV6Only)
{
bind6(address, reuseAddress, true, ipV6Only);
}

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions