Skip to content

unescape Backslash char in UTF8 unescape method#2866

Closed
vfjpl wants to merge 1 commit intopocoproject:masterfrom
vfjpl:master
Closed

unescape Backslash char in UTF8 unescape method#2866
vfjpl wants to merge 1 commit intopocoproject:masterfrom
vfjpl:master

Conversation

@vfjpl
Copy link
Copy Markdown
Contributor

@vfjpl vfjpl commented Dec 16, 2019

This PR fixes UTF8::unescape() method. This method was lacking a unecaping for \ character. I added it and also changed big if else ladder to switch case. testsuite is also updated to test backslash unescaping.

@obiltschnig
Copy link
Copy Markdown
Member

Please re-target against poco-1.10.0 branch. Thank you.

@vfjpl
Copy link
Copy Markdown
Contributor Author

vfjpl commented Dec 16, 2019

@obiltschnig done in #2867
Also I think It would be a good idea to state clearly in CONTRIBUTING.md that contributors should not create pull requests against master :)

@obiltschnig
Copy link
Copy Markdown
Member

merged #2867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants