X509Certificate: Get rid of deprecated OpenSSL 1.1 APIs#2827
Merged
obiltschnig merged 1 commit intopocoproject:poco-1.10.0from Nov 4, 2019
neheb:patch-2
Merged
X509Certificate: Get rid of deprecated OpenSSL 1.1 APIs#2827obiltschnig merged 1 commit intopocoproject:poco-1.10.0from neheb:patch-2
obiltschnig merged 1 commit intopocoproject:poco-1.10.0from
neheb:patch-2
Conversation
Member
|
Please re-target your PR against poco-1.10.0 branch. |
Added a missing implicit header and added compatibility macros. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Contributor
Author
|
I think that should do it. |
neheb
commented
Nov 4, 2019
| if (name->type == GEN_DNS) | ||
| { | ||
| const char* data = reinterpret_cast<char*>(ASN1_STRING_data(name->d.ia5)); | ||
| const char* data = reinterpret_cast<char*>(ASN1_STRING_get0_data(name->d.ia5)); |
Contributor
Author
There was a problem hiding this comment.
My C++ is poor but note that ASN1_STRING_get0_data returns const unsigned char* whereas ASN1_STRING_data returns unsigned char*. There might be a const_cast needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a missing implicit header and added compatibility macros.
Signed-off-by: Rosen Penev rosenp@gmail.com