allow pre-allocation of the buffer in LogStreamBuf#2791
Closed
killerbot242 wants to merge 1 commit intopocoproject:developfrom
Closed
allow pre-allocation of the buffer in LogStreamBuf#2791killerbot242 wants to merge 1 commit intopocoproject:developfrom
killerbot242 wants to merge 1 commit intopocoproject:developfrom
Conversation
Author
|
I had a look at the failing unit test : testIndex: !!!FAILURES!!! Runs: 829 Failures: 0 Errors: 1 There was 1 error: 1: N7CppUnit10TestCallerI15ExpireCacheTestEE.testAccessExpireN failed=Foundation I am unable to relate this to my pull request, do you have any ideas ???? |
Author
|
Hi, |
Member
|
Sorry, that was an unintended side effect of renaming the develop branch, which unfortunately closed all open PRs. |
Member
|
merged into 1.10.1 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOAL : allowing pre-allocation of the buffer in LogStreamBuf
RATIONALE:
Like any iostream buffer, LogStreamBuf comes with an unknown buffer space pre-allocated. When the logging messages are long, it can induce a number of realloc. Pre-allocating the buffer allows to avoid those expensive reallocations. This is important when the logging happens often (inside a loop that is repeated a lot).