Fix the issue with incorrect type of store name parameter in CertOpenStore API call into NetSSL_Win#2773
Merged
obiltschnig merged 1 commit intopocoproject:developfrom Aug 22, 2019
Conversation
…ertOpenStore api call into NetSSL_Win
Member
|
Also merged into poco-1.10.0 branch in 0784665 |
obiltschnig
added a commit
that referenced
this pull request
Aug 22, 2019
…ameter in CertOpenStore API call into NetSSL_Win
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were unable to load SSL certificates from the Windows certificate store with the OPT_USE_MACHINE_STORE option enabled.
During debugging, we found that the problem was in calling the Windows CertOpenStore API function.
According to the documentation, if you use the CERT_STORE_PROV_SYSTEM parameter, the pvPara parameter must point to a Unicode string that contains the name of the system storage. But in fact, the pvPara parameter pointed to the Ansi string.
Therefore, we changed the std::string certStoreName parameter to std::wstring wcertStore.
We checked this solution. Currently, we can load SSL certificates from the Windows certificate store with the OPT_USE_MACHINE_STORE option enabled.