Omit ContentLength in WebSocket accept response#2336
Merged
obiltschnig merged 1 commit intopocoproject:developfrom Jun 11, 2019
Merged
Conversation
Author
|
Ping? |
Author
|
This bug breaks web socket compatibility to other implementations (e.g., .NET). Check also results from https://github.com/crossbario/autobahn-testsuite |
|
Is there anything I can do to expediate the merge of this PR? The current implementation does not work with the (standards-conform) client we are using. It seems like a straightforward and correct commit. |
acc276e to
a32f40a
Compare
Member
|
Need to merge into 1.10 as well. |
Author
|
Should I open another PR against a release branch or what is the procedure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://tools.ietf.org/html/rfc7230#section-3.3.2
(see https://stackoverflow.com/a/44553521/8647581 for details)