Support building poco 1.8.0 as cmake sub-project#1991
Closed
guruofquality wants to merge 1 commit intopocoproject:masterfrom
Closed
Support building poco 1.8.0 as cmake sub-project#1991guruofquality wants to merge 1 commit intopocoproject:masterfrom
guruofquality wants to merge 1 commit intopocoproject:masterfrom
Conversation
The key here was replacing a few instances of CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR so cmake/test_compiler.cpp can be properly located in cmake/CXX1x.cmake.
Member
|
Merged manually. Please don't submit pull requests against master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I support optionally building poco as a cmake subproject/git submodule. After updating to 1.8.0 series, I had to make the following minor change due to use of cmake variables. This is a pretty simple substitution and should be non-breaking for any use case.
The key here was replacing a few instances of CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR so cmake/test_compiler.cpp can be properly located in cmake/CXX1x.cmake. I also replaced CMAKE_BINARY_DIR with PROJECT_BINARY_DIR in this file to be consistent, but that wasn't actually an issue.