Use stable_sort to preserve order of IP addresses from DNS#1445
Merged
obiltschnig merged 1 commit intopocoproject:developfrom Oct 5, 2016
Merged
Use stable_sort to preserve order of IP addresses from DNS#1445obiltschnig merged 1 commit intopocoproject:developfrom
obiltschnig merged 1 commit intopocoproject:developfrom
Conversation
|
Nice catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SocketAddress uses a sort operation on IP addresses returned from DNS to ensure that IPv4 addresses are preferred over IPv6 addresses. Unfortunately, std::sort does not guarantee that the order of "equal" elements will be preserved, in which case SocketAddress can wind up with an IP other than the first one when multiple addresses are returned. Since DNS round robin-ing (https://en.wikipedia.org/wiki/Round-robin_DNS) assumes that a client will typically use the first address, it would be beneficial to have the order preserved by the sort. Switching to std::stable_sort achieves this.