Skip to content

Conversation

@gee1k
Copy link
Contributor

@gee1k gee1k commented Nov 4, 2019


name: Support new player
about: Create a pull request to contribute in making Pock amazing!
title: 'Support new player'
labels: ''
assignees: ''


Describe the Pull request
Nowplaying feature supports Alibaba's Shrimp Player

Screenshots
image

Pull request type

  • New feature (non-breaking change which adds functionality)

Test Configuration:

  • Hardware: [MacBook Pro, 15 (Late 2018)]
  • macOS Version: [10.5.1]
  • Xcode version: [11.1]

Checklist
Use this list to keep track of your progress:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@pigigaldi pigigaldi merged commit 2d04796 into pock:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants