Skip to content

Conversation

@lcukerd
Copy link
Contributor

@lcukerd lcukerd commented Jul 28, 2019

Features Added:

  • Option to choose between 24-hour and 12-hour clock format

Fixes (That I found during my usage, don't know if there are any open issues for same):

  • Incorrect long tap zone when the number of items in the Control Center widget is not 4
  • Incorrect left or right icon is shown for SlideableController when only one of (up or down) brightness or volume was enabled.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Tested? (Nothing much)

  • Try toggling time format
  • Try adding or removing different Control Center widget items and then testing long tap zone and icons of SlideableController

Test Configuration:

  • Hardware: Macbook pro 2019 i9 (*required)
  • macOS Version: 10.14.6
  • Xcode version: 10.3

Checklist
Use this list to keep track of your progress:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Notes:
I have done some changes to build files that were required for my machine to allow the successful building of the app. I was able to run the app but not archiving. However, I am sure the application will run fine as long as you only merge actual code changes.

I have also added a list of my Todo. Please free to ignore them when merging. I might be working on them on my next weekend. Most of the remaining Todo are features. Would be great if you could push a release on these fixes, if possible.

Thank you for creating this App

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants