Feature: Mute Button #172
Merged
Feature: Mute Button #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pigigaldi
reviewed
Jul 24, 2019
Pock/Preferences/Preferences.swift
Outdated
| static let shouldShowBrightnessUpItem = Defaults.Key<Bool>("shouldShowBrightnessUpItem", default: true) | ||
| static let shouldShowVolumeDownItem = Defaults.Key<Bool>("shouldShowVolumeDownItem", default: true) | ||
| static let shouldShowVolumeUpItem = Defaults.Key<Bool>("shouldShowVolumeUpItem", default: true) | ||
| static let shouldShowToggleMuteItem = Defaults.Key<Bool>("shouldShowToggleMuteItem", default: true) |
Collaborator
There was a problem hiding this comment.
I think it is better to have this option false by default.
pigigaldi
reviewed
Jul 24, 2019
| case is CCVolumeUpItem, is CCVolumeDownItem: | ||
| slideableController?.set(downItem: volumeItems.first, upItem: volumeItems.last) | ||
| case is CCVolumeUpItem, is CCVolumeDownItem, is CCToggleMuteItem: | ||
| slideableController?.set(downItem: CCVolumeUpItem(parentWidget: self), upItem: CCVolumeDownItem(parentWidget: self)) |
Collaborator
There was a problem hiding this comment.
downItem should be CCVolumeDownItem and upItem should be CCVolumeUpItem 🌚
pigigaldi
requested changes
Jul 24, 2019
Collaborator
pigigaldi
left a comment
There was a problem hiding this comment.
I added a few comments for some little things I think should be addressed before I can merge this excellent PR 👍
pigigaldi
approved these changes
Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request to contribute in making Pock amazing!
title: ''
labels: ''
assignees: ''
Describe the Pull request
volumeItemswith new copies of each buttonsScreenshots
Fixes
A comma-separated list of issues that can be closed with this PR.
[e.g. #1, #2, #3 (*required)]#155
Pull request type
Keep only the option that better matches your pull request.
Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so I can reproduce.
Please, remember to fill the
Test Configurationsection with requested details.Test Configuration:
Checklist
Use this list to keep track of your progress: