docs: update pnpr docs for registries, ordered sources, and per-registry packages maps#834
Conversation
…maps Documents the redesigned model from pnpm/pnpm#12773, pnpm/pnpm#12778, and pnpm/pnpm#12787: - mounts:/defaultTarget: -> registries:/defaultRegistry: - routers collapse to ordered sources: lists; a package resolves to the first listed source whose declared packages claim it - the namespace and ACL merge into per-registry packages: maps, with most-specific-key selection and namespace enforcement on every path - the registry: config toggle is gone; the npm-registry surface is served iff at least one registry is declared, minus --disable-registry - the account (login/token) endpoints are always served on every tier
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
|
| Layer / File(s) | Summary |
|---|---|
Core configuration model rewrite pnpr-docs/configuration.md |
Replaces mount-based routing docs with registries/defaultRegistry model: hosted/upstream/router kinds, packages map pattern language, groups, secret/HMAC semantics, and registry/resolver surface behavior. |
CLI flag description update pnpr-docs/cli.md |
Narrows --disable-registry description to match the new registry surface semantics, removing the registry.enabled override claim. |
Endpoint availability and routing docs pnpr-docs/endpoints.md |
Rewrites always-on endpoints, registry/resolver surfaces, allowlist wording, and read/write/user-token endpoint routing to use registries language. |
Install acceleration doc updates pnpr-docs/install-acceleration.md |
Updates allowlist, private registry configuration, tarball URL format, and login/auth wording from mounts to registries. |
Introduction and quick-start rewrites pnpr-docs/introduction.md, pnpr-docs/quick-start.md |
Updates routing explanation and example pnpr.yaml to use registries/defaultRegistry with hosted local and upstream npmjs registries. |
Storage example update pnpr-docs/storage.md |
Updates Cloudflare R2 example to use registries.local with a packages map and router sources/defaultRegistry instead of mounts/routes/defaultTarget. |
Estimated code review effort: 2 (Simple) | ~12 minutes
Possibly related PRs
- pnpm/pnpm.io#829: Added the initial pnpr docs pages for the same files (
cli.md,configuration.md, etc.) that this PR rewrites.
Poem
Mounts once stood where registries now grow,
A rabbit hops through docs, row by row,
"sources" and "defaultRegistry" take their place,
No fall-through here, just a tidy namespace,
🐇 Thump-thump — the config docs now glow!
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately summarizes the main documentation changes around registries, ordered sources, and packages maps. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
update-pnpr-dox2
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
PR Summary by QodoDocs: align pnpr docs with registries, ordered router sources, and packages maps
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
Updates the pnpr docs for the redesigned configuration model shipped in pnpm/pnpm#12773, pnpm/pnpm#12778, and pnpm/pnpm#12787. pnpr is pre-1.0, so the docs describe the new design outright — no mention of the old keys and no migration notes.
configuration.md—mounts:/defaultTarget:→registries:/defaultRegistry:throughout. New Thepackagesmap section: keys are the registry's declared namespace (same four-shape pattern language), values are per-packageaccess/publish/unpublishrules, the most specific matching key wins and key order carries no meaning. Routers are documented as orderedsources:lists (first source whose packages claim the name wins; a map-less catch-all must be last) with the updated validation matrix. Hosted registries document the tiered denial shapes (404 mask vs loud 401/403); upstreams document the two map rules (per-packageaccessallowed onpublic: true, write rules rejected). The top-levelpackages:ACL section and theregistry:toggle are gone, replaced by The registry surface andresolver: the npm-registry surface is served iff at least one registry is declared,--disable-registryoverrides per process, and a nothing-to-serve config is a startup error.endpoints.md— registry-surface gating described as derived fromregistries:; the user/token endpoints are documented as always mounted on every tier (sopnpm loginworks against a resolver-only server); routing bullets updated forsources:dispatch and namespace enforcement on every path.quick-start.md,storage.md— example configs rewritten to the new shape.cli.md—--disable-registryreworded.install-acceleration.md— terminology/anchors updated; notes that login works even against a resolver-only server.introduction.md— overview sentence updated.Verified: the site builds cleanly and every new cross-reference anchor exists in the generated HTML; the
'@corp/*': {}example shape matches the pnpr config test suite.Summary by CodeRabbit