Merged
Conversation
Resolves #9217
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a feature to replace a leading tilde in path strings with the provided home directory, addressing issue #9217. Key changes include new functions for path transformation, updated tests to verify the behavior, and a configuration change to include a new key ("globalBinDir").
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| config/config/test/transformPath.test.ts | Added tests for transformPath and transformPathKeys |
| config/config/src/transformPath.ts | Introduced transformPath and transformPathKeys |
| config/config/src/index.ts | Applied transformPathKeys in getConfig |
| config/config/src/Config.ts | Added globalBinDir to the configuration interface |
| .changeset/nasty-paws-cut.md | Documented changes for the release |
Comments suppressed due to low confidence (1)
config/config/test/transformPath.test.ts:20
- Consider expanding the transformPathKeys test to include all keys defined in PATH_KEYS (e.g., globalBinDir, globalDir, pnpmHomeDir) to ensure consistent path transformation across all properties.
test('transformPathKeys', () => {
zkochan
approved these changes
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9217