Skip to content

fix(exec): add missing node-options to recursive run#9264

Merged
zkochan merged 3 commits intomainfrom
node-options-when-filtering-9184
Mar 11, 2025
Merged

fix(exec): add missing node-options to recursive run#9264
zkochan merged 3 commits intomainfrom
node-options-when-filtering-9184

Conversation

@KSXGitHub
Copy link
Contributor

Fixes #9180

@zkochan
Copy link
Member

zkochan commented Mar 11, 2025

Is it missing anywhere else? Like the non-recursive run or pnpm exec?

@KSXGitHub
Copy link
Contributor Author

Is it missing anywhere else? Like the non-recursive run or pnpm exec?

Nope.

pnpm --recursive exec node -p process.env.NODE_OPTIONS would print the expected node option.

@KSXGitHub KSXGitHub changed the title fix(run): add missing node-options to recursive fix(exec): add missing node-options to recursive run Mar 11, 2025
@zkochan
Copy link
Member

zkochan commented Mar 11, 2025

extraEnv is already extended in run.ts, why don't you just move that code before runRecursive?

@zkochan zkochan merged commit 57f989e into main Mar 11, 2025
16 checks passed
@zkochan zkochan deleted the node-options-when-filtering-9184 branch March 11, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.npmrc node-options not applied when filtering

2 participants