Conversation
zkochan
reviewed
Mar 11, 2025
Member
zkochan
left a comment
There was a problem hiding this comment.
Can we use test.each and just pass the different nodeLinker values?
Member
Author
|
Yes, definitely. I should have done that from the start. |
84abd06 to
e8a1431
Compare
zkochan
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See motivation at:
Changes
When a future commit updates
allProjectsGraphto always contains the full project graph, I'd like to make sure we don't accidentally inject all workspace packages on apnpm deploy. Only the selected workspace package should be injected into the deployed dir, not theallProjectsGraph.Adding 2 new tests to make sure this doesn't accidentally break in the future.