Skip to content

fix: updateWorkspaceManifest not writing to manifest file#9171

Merged
zkochan merged 3 commits intopnpm:mainfrom
rp-pedraza:fix_updateworkspacemanifest
Feb 26, 2025
Merged

fix: updateWorkspaceManifest not writing to manifest file#9171
zkochan merged 3 commits intopnpm:mainfrom
rp-pedraza:fix_updateworkspacemanifest

Conversation

@rp-pedraza
Copy link
Contributor

close #9168

@rp-pedraza rp-pedraza requested a review from zkochan as a code owner February 26, 2025 02:09
@rp-pedraza
Copy link
Contributor Author

Not sure how to add a test on this one.

@zkochan
Copy link
Member

zkochan commented Feb 26, 2025

Thanks, I'll add a test.

@zkochan zkochan merged commit 23754c7 into pnpm:main Feb 26, 2025
9 checks passed
@rp-pedraza
Copy link
Contributor Author

@zkochan Thanks as well. I didn't see your message so I ended up creating a test too but your version is better. Please ignore the extra commit notifications I made in #9168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: 'EISDIR: illegal operation on a directory, rename' during pnpm approve-builds

2 participants