Skip to content

fix(lifecycle): properly quote args#8986

Closed
yoursunny wants to merge 1 commit intopnpm:v9from
yoursunny:lifecycle-quote
Closed

fix(lifecycle): properly quote args#8986
yoursunny wants to merge 1 commit intopnpm:v9from
yoursunny:lifecycle-quote

Conversation

@yoursunny
Copy link
Contributor

fixes #8980
fixes #7641

@yoursunny yoursunny requested a review from zkochan as a code owner January 17, 2025 17:42
@welcome
Copy link

welcome bot commented Jan 17, 2025

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@socket-security
Copy link

socket-security bot commented Jan 17, 2025

@socket-security
Copy link

socket-security bot commented Jan 17, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/minimist@1.2.0 ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/minimist@1.2.0

@zkochan
Copy link
Member

zkochan commented Jan 26, 2025

The tests are failing.

@yoursunny
Copy link
Contributor Author

#9018 is the same fix targeting v10 branch.

@zkochan
Copy link
Member

zkochan commented Jan 29, 2025

merged to v9 7eff24d

@zkochan zkochan closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants