feat!: prevent nonsense peerDependencies#8942
Conversation
|
I don't think aliases make sense in peer deps. Also, why should it be validated? Doesn't it already fail during peer dependencies resolution? What happens currently? |
It doesn't seem to be the case. The "bug" in #8934 was possible because
I added it because I'm not sure what exactly is allowed and not allowed. But if you want to remove it, I'll remove it. |
| 'use-workspace': 'workspace:^', | ||
| 'use-catalog': 'catalog:', |
There was a problem hiding this comment.
These are only valid for packages from the workspace but you validate all dependencies at the moment. Maybe just validate packages from the workspace.
There was a problem hiding this comment.
I have moved the call to validatePeerDependencies to toResolveImporter: 924a868
Closes #8934