feat(audit): add ability to ignore Github Security Advisory#8483
Merged
feat(audit): add ability to ignore Github Security Advisory#8483
Conversation
zkochan
reviewed
Aug 31, 2024
pnpm/src/main.ts
Outdated
Comment on lines
+77
to
+80
| // eslint-disable-next-line @typescript-eslint/restrict-template-expressions | ||
| deprecationMsg += ` ${chalk.yellow(`Deprecated option: '${unknownOptionsArray[0]}'`)}` | ||
| } else { | ||
| // eslint-disable-next-line @typescript-eslint/restrict-template-expressions |
Member
There was a problem hiding this comment.
why were this comments added? This file wasn't modified.
Contributor
Author
There was a problem hiding this comment.
The pre-commit hooks kept failing on these lines specifically, even though I did not touch them. I added the ignore so I could push the PR.
Member
There was a problem hiding this comment.
ok, well you should fix the warning then. Not ignore it. Maybe something like
deprecationMsg += ` ${chalk.yellow(`Deprecated option: '${unknownOptionsArray[0] as string}'`)}`
Member
|
please, add changesets as described in contributing.md |
zkochan
approved these changes
Sep 1, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6838
Adds
ignoreGhsasconfig option so that you can also target a Github Security Advisory to be ignored