fix: skip cataloged dependencies when running pnpm update --latest#8286
Merged
fix: skip cataloged dependencies when running pnpm update --latest#8286
pnpm update --latest#8286Conversation
df36feb to
0ebae6a
Compare
gluxon
commented
Jul 7, 2024
zkochan
reviewed
Jul 7, 2024
zkochan
approved these changes
Jul 7, 2024
4627d37 to
0ebae6a
Compare
0ebae6a to
e5003d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
pnpm update --latestcurrently causes a consistency bug. Sincepnpm updatedoesn't know how to updatepnpm-workspace.yamlyet,^1.0.0) of a cataloged dependency would still be present inpnpm-workspace.yaml,3.1.0) would be present inpnpm-workspace.yamland installed on disk.Changes
Let's skip over
catalog:protocol dependencies untilpnpm updateis refactored to handlepnpm-workspace.yamledits in the future.