fix: reuse existing cataloged resolutions for consistency#8259
Merged
Conversation
b8b3342 to
cb5818c
Compare
cb5818c to
a871237
Compare
zkochan
approved these changes
Jun 30, 2024
This was referenced Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In cases where multiple versions of a dependency are present in
pnpm-lock.yaml, I believe users will expect dependencies using thecatalog:protocol to all resolve to the same version.In other words, a lockfile that looks like this would be surprising:
Changes
If there's already a catalog resolution in the
pnpm-lock.yamlfile, use the version field.